Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_js_analytics.py:85-90: Test Yandex ecommerce goals.... #799

Closed
0pdd opened this issue Mar 31, 2019 · 5 comments
Closed

tests_js_analytics.py:85-90: Test Yandex ecommerce goals.... #799

0pdd opened this issue Mar 31, 2019 · 5 comments
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable front markup or work with js

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 31, 2019

The puzzle 785-951da4fc from #785 has to be resolved:

shopelectro/shopelectro/tests/tests_js_analytics.py

Lines 85 to 90 in 9053a01

# @todo #785:60m Test Yandex ecommerce goals.
# Here are goals left to test:
# - onCartClear from cart
# - onProductAdd from catalog, product and order pages
# - onProductRemove from cart and order page
# - onProductDetail from product page

The puzzle was created by Artemiy on 31-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 31, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 31, 2019
@ArtemijRodionov
#785 test yandex ecommerce (#798)
9053a01 
* Create test for yandex ecommerce purchase

* Create todo for yandex ecommerce tests

* Review fixes
This was referenced Mar 31, 2019
Closed
Closed
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable front markup or work with js labels Mar 31, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Mar 31, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Apr 1, 2019
Merged
@ArtemijRodionov ArtemijRodionov added x2 task's price doubled. Usually because of burning and removed x2 task's price doubled. Usually because of burning labels Apr 1, 2019
ArtemijRodionov added a commit that referenced this issue Apr 8, 2019
@ArtemijRodionov
#799 test yandex ecommerce (#800)
73af98b 
* Create ProductPage for selenium tests

* Create tests for product detail goal

* Create CartPosition element

* Update issue number for todo

* Create file with exceptions for elements

* Apply linter rules and review fixes
This was referenced Apr 8, 2019
Open
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 8, 2019

@0pdd 2 puzzles #807, #808 are still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Jun 30, 2019

@0pdd 3 puzzles #807, #920, #921 are still not solved; solved: #808.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@0pdd 4 puzzles #807, #929, #930, #938 are still not solved; solved: #808, #920, #921.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 12, 2019

@0pdd 3 puzzles #807, #930, #940 are still not solved; solved: #808, #920, #921, #929, #938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable front markup or work with js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd