Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog.py:27-30: Create tests for the catalog matrix.... #836

Closed
0pdd opened this issue Apr 30, 2019 · 2 comments · Fixed by #874
Closed

catalog.py:27-30: Create tests for the catalog matrix.... #836

0pdd opened this issue Apr 30, 2019 · 2 comments · Fixed by #874
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 30, 2019

The puzzle 822-663573d7 from #822 has to be resolved:

shopelectro/shopelectro/views/catalog.py

Lines 27 to 30 in c89b807

# @todo #822:60m Create tests for the catalog matrix.
# This cases are would be good to test:
# - Matrix sorting by page position
# - Block items limiting

The puzzle was created by duker33 on 30-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 30, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Apr 30, 2019
@duker33
#822 Create categories matrix page (#829)
c89b807 
* #822  Draft for categories matrix

* #822  Markup for category matrix

* #fix  grade refarm version

* #822  Limit category matrix items

* #822  Subtask category matrix tests

* #822  Disable failed test and subtask filter resurrection

* #822  Subtask documenting category matrix functionality
@0pdd 0pdd mentioned this issue Apr 30, 2019
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it labels May 1, 2019
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Jun 11, 2019
@duker33 duker33 self-assigned this Jun 11, 2019
duker33 added a commit that referenced this issue Jun 11, 2019
@duker33
#836 Tests for the catalog matrix
e54e251
@duker33
Copy link
Contributor

duker33 commented Jun 11, 2019

avoided block size testing

@duker33 duker33 mentioned this issue Jun 11, 2019
Merged
duker33 added a commit that referenced this issue Jun 12, 2019
@duker33
#836 Tests for the catalog matrix
0841eee
duker33 added a commit that referenced this issue Jun 12, 2019
@duker33
#836 Review#1 fix. Drop reverse_lazy
8c26fb4
duker33 added a commit that referenced this issue Jun 15, 2019
@duker33
#836 Minor fix for the new test
0ec8fc3
duker33 added a commit that referenced this issue Jun 15, 2019
@duker33
#836 Test categories matrix sorting (#874)
2579632 
* #836  Tests for the catalog matrix

* #836  Review#1 fix. Drop reverse_lazy

* #836  Minor fix for the new test
duker33 added a commit that referenced this issue Jun 17, 2019
@duker33
#836 Fix selenium tests
790e6d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#836 Test categories matrix sorting fidals/shopelectro
2 participants
@duker33 @0pdd