Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium_admin.py:62-64: Fix admin filter tests... #851

Open
0pdd opened this issue May 17, 2019 · 1 comment
Open

tests_selenium_admin.py:62-64: Fix admin filter tests... #851

0pdd opened this issue May 17, 2019 · 1 comment
Labels
1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented May 17, 2019

The puzzle 835-d813aa49 from #835 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium_admin.py

Lines 62 to 64 in b8929fe

# @todo #835:60m Fix admin filter tests
# Tests rely upon order of html markup.
# It is fragile and always breaks after admin filter modifications.

The puzzle was created by Artemiy on 17-May-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented May 17, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue May 17, 2019
@ArtemijRodionov
#835 admin price filter (#848)
b8929fe 
* Fix product price filter for admin panel

* Create few receipts for Makefile

* Fix typo in ProductPriceFilter

* Add price field to AdminProductPage

* Fix related tests
This was referenced May 17, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 hour typical issue size. It's one pdd hour 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd