Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update font-awesome css dependency #894

Closed
duker33 opened this issue Jun 24, 2019 · 2 comments · Fixed by #959
Closed

Update font-awesome css dependency #894

duker33 opened this issue Jun 24, 2019 · 2 comments · Fixed by #959
Assignees
@duker33
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix easy new teammates can start with such issues to become familiar with project front markup or work with js

Comments

@duker33
Copy link
Contributor

duker33 commented Jun 24, 2019

The current has not required icons

#890 (comment)
@duker33 duker33 added 15 mins small issues. Usually cosmetic fixes 1 burning issue easy new teammates can start with such issues to become familiar with project front markup or work with js labels Jun 24, 2019
@duker33 duker33 self-assigned this Jun 24, 2019
@duker33
Copy link
Contributor Author

duker33 commented Sep 16, 2019

the new font-awesome has some path and var issues to integrate. I'll do it in the same task

@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix and removed 15 mins small issues. Usually cosmetic fixes labels Sep 16, 2019
duker33 added a commit that referenced this issue Sep 16, 2019
@duker33
#894 Update font-awesome to the latest version
de69b8d
@duker33 duker33 mentioned this issue Sep 16, 2019
Merged
duker33 added a commit that referenced this issue Sep 18, 2019
@duker33
#894 Revert back font-awesome. Add pdd task to finish upgrade
890635d
duker33 added a commit that referenced this issue Sep 18, 2019
@duker33
#894 Update font-awesome to the latest version (#959)
edfb9f8 
* #894  Update font-awesome to the latest version

* #894  Revert back font-awesome. Add pdd task to finish upgrade
@0pdd 0pdd mentioned this issue Sep 18, 2019
Closed
@0pdd
Copy link
Collaborator

0pdd commented Sep 18, 2019

@duker33 the puzzle #962 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix easy new teammates can start with such issues to become familiar with project front markup or work with js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#894 Update font-awesome to the latest version fidals/shopelectro
2 participants
@duker33 @0pdd