Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models.py:77-78: Use MatrixBlock in the matrix view. Get... #935

Closed
0pdd opened this issue Jul 4, 2019 · 1 comment · Fixed by #936
Closed

models.py:77-78: Use MatrixBlock in the matrix view. Get... #935

0pdd opened this issue Jul 4, 2019 · 1 comment · Fixed by #936
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 4, 2019

The puzzle 880-51a8e904 from #880 has to be resolved:

shopelectro/shopelectro/models.py

Lines 77 to 78 in 6ed0777

# @todo #880:60m Use MatrixBlock in the matrix view.
# Get the block_size data from the matrix view and fill out the model.

The puzzle was created by Artemiy on 04-Jul-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 4, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 4, 2019
@ArtemijRodionov
#880 Create CatalogBlock model (#925)
6ed0777 
* Create CatalogBlock model and add sublime's configs to .gitignore

* Remove related todo

* Review fixes

* Rework MatrixBlock tests
This was referenced Jul 4, 2019
Closed
Closed
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this Jul 4, 2019
@ArtemijRodionov ArtemijRodionov added 1 burning issue 1 hour typical issue size. It's one pdd hour cleanup everything that do project stronger, flexible, reusable labels Jul 4, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jul 4, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jul 5, 2019
@ArtemijRodionov
#935 matrix block view (#936)
1fca36d 
* Create data migration for MatrixBlock

* Drop old media

* Create MatrixBlock fixtures

* Fix MatrixBlock.name/url

* Adapt matrix view to MatrixBlock

* Adapt BlockMatrix tests

* Gen fixture

* Review fixes

* Apply linter rules

* Fix liter warnings
0pdd referenced this issue Jul 6, 2019
@ArtemijRodionov
#863 #934 Add MatrixBlock to admin panel. Localize fields (#941)
db12eb7 
* Add MatrixBlock to admin panel. Localize fields

* Delete todos

* Recompile translate. Edit in_pack colModel

* Create todo to fix i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#935 matrix block view fidals/shopelectro
2 participants
@ArtemijRodionov @0pdd