Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile:101-102: Wait user approval for make i18n See... #942

Closed
0pdd opened this issue Jul 6, 2019 · 1 comment · Fixed by #966
Closed

Makefile:101-102: Wait user approval for make i18n See... #942

0pdd opened this issue Jul 6, 2019 · 1 comment · Fixed by #966
Assignees
@duker33
Labels
3 we can defer this issue. But it'll good to implement it 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 6, 2019

The puzzle 934-a8735256 from #934 has to be resolved:

shopelectro/docker/Makefile

Lines 101 to 102 in db12eb7

# @todo #934:15m Wait user approval for `make i18n`
# See the parent issue for details

The puzzle was created by @artemiy312 on 06-Jul-19.

Estimate: 15 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 6, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 6, 2019
@ArtemijRodionov
#863 #934 Add MatrixBlock to admin panel. Localize fields (#941)
db12eb7 
* Add MatrixBlock to admin panel. Localize fields

* Delete todos

* Recompile translate. Edit in_pack colModel

* Create todo to fix i18n
This was referenced Jul 6, 2019
Closed
Closed
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 15 mins small issues. Usually cosmetic fixes 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it labels Jul 6, 2019
duker33 added a commit that referenced this issue Sep 22, 2019
@duker33
#942 Wait user approval to compile already made messages
a08b286
@duker33 duker33 mentioned this issue Sep 22, 2019
Merged
@duker33 duker33 self-assigned this Sep 22, 2019
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Sep 22, 2019
duker33 added a commit that referenced this issue Sep 24, 2019
@duker33
#942 Wait user approval to compile already made messages (#966)
67179b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
3 we can defer this issue. But it'll good to implement it 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#942 Wait user approval to compile already made messages fidals/shopelectro
3 participants
@duker33 @ArtemijRodionov @0pdd