Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_js_analytics.py:90-91: Test Yandex ecommerce... #944

Open
0pdd opened this issue Jul 12, 2019 · 1 comment
Open

tests_js_analytics.py:90-91: Test Yandex ecommerce... #944

0pdd opened this issue Jul 12, 2019 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable front markup or work with js Metrics feature about business metrics

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 12, 2019

The puzzle 939-a904eb4b from #939 has to be resolved:

shopelectro/shopelectro/tests/tests_js_analytics.py

Lines 90 to 91 in 4ddb192

# @todo #939:120m Test Yandex ecommerce increase/decrease/set goals from the order page.
# Create assertion for cart clear goal.

The puzzle was created by Artemiy on 12-Jul-19.

Estimate: 120 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 12, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 12, 2019
@ArtemijRodionov
#938 #939 test order page remove goal (#943)
4ddb192 
* Create Positions selenium element

* Reuse Positions for Cart class

* Create OrderPositions class

* Adopt classes to Positions

* Implement OrderPage class

* Create YandexEcommerce.remove_from_order_page test. Reduce code duplication

* Apply linter rules

* Fix typo

* Review fixes

* Edit todo to fix assertion for cart clear goal

* Apply linter rules
This was referenced Jul 12, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this Jul 12, 2019
@ArtemijRodionov ArtemijRodionov added 1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable front markup or work with js Metrics feature about business metrics labels Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable front markup or work with js Metrics feature about business metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd