Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_views.py:546: Repair category siblings mech. #961

Closed
0pdd opened this issue Sep 18, 2019 · 2 comments · Fixed by #967
Closed

tests_views.py:546: Repair category siblings mech. #961

0pdd opened this issue Sep 18, 2019 · 2 comments · Fixed by #967
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug from seo

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 18, 2019

The puzzle 887-c7e6a145 from #887 has to be resolved:

shopelectro/shopelectro/tests/tests_views.py

Line 546 in 2877085

# @todo #887:60m Repair category siblings mech.

The puzzle was created by duker33 on 18-Sep-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 18, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Sep 18, 2019
@duker33
#952 Test category root crumb siblings (#957)
2877085 
* #952  Test root crumbs

* #887  Prove category siblings failure with test
@0pdd 0pdd mentioned this issue Sep 18, 2019
Closed
@duker33 duker33 self-assigned this Sep 18, 2019
@duker33 duker33 added 1 burning issue 1 hour typical issue size. It's one pdd hour bug from seo labels Sep 18, 2019
@duker33 duker33 mentioned this issue Sep 18, 2019
Closed
@duker33 duker33 added the blocked issue is blocked by another issue label Sep 18, 2019
@duker33
Copy link
Contributor

duker33 commented Sep 18, 2019

depends from fidals/refarm-site#343

@duker33 duker33 added blocked issue is blocked by another issue and removed blocked issue is blocked by another issue labels Sep 22, 2019
duker33 added a commit that referenced this issue Sep 22, 2019
@duker33
#961 Adapt breadcrumbs to the new refarm-site api
e3302cd
@duker33 duker33 mentioned this issue Sep 22, 2019
Merged
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#961 Review#1 minor style fixes
c43ddc5
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#961 Grade refarm-site dep to 0.7.1 version
cdccbaf
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#961 Fix Product page microdata. Add custom breadcrumbs template to i…
5f84240 
…mplement `hidden-xs hidden-sm` css props
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#961 Trigger build
cfc780f
@duker33 duker33 removed the blocked issue is blocked by another issue label Sep 23, 2019
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#961 Trigger build
863a5eb
duker33 added a commit that referenced this issue Sep 24, 2019
@duker33
#961 Fix hardcoded selenium crumbs tests
c2b2803
duker33 added a commit that referenced this issue Sep 24, 2019
@duker33
#961 Adapt breadcrumbs to the new refarm-site api (#967)
ea63381 
* #961  Adapt breadcrumbs to the new refarm-site api

* rf#345  Adapt to the minor crumbs interface change

* #961  Review#1 minor style fixes

* #961  Grade refarm-site dep to 0.7.1 version

* #968  Fix category microdata

#968  Fix category mictodata

* #961  Fix Product page microdata. Add custom breadcrumbs template to implement `hidden-xs hidden-sm` css props

* #961  Fix hardcoded selenium crumbs tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug from seo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#961 #968 Adapt breadcrumbs to the new refarm-site api. Fix microdata fidals/shopelectro
2 participants
@duker33 @0pdd