#973 Add an html validator #1020
Conversation
|
@olegush , add plz "Closes #XXX" to the task body |
templates/valid_example.html
Outdated
| @@ -0,0 +1,12 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
- the file should live in
tests/assets/ valid_markup_example.htmlwould be more good name for the file
| if file_ext == '.html': | ||
| validate(render_to_string(filepath)) | ||
|
|
||
| def test_valid_example(self): |
There was a problem hiding this comment.
you also should test not valid html
shopelectro/tests/tests_html.py
Outdated
| ) | ||
| validate(render_to_string(filepath)) | ||
|
|
||
| @unittest.expectedFailure |
There was a problem hiding this comment.
use assertRaises instead of expectedFailure. The last one should be used only for tests that should be fixed in the future.
It should look like this:
with self.assertRaises(TypeError):
s.split(2)
| @tag('fast') | ||
| class TemplateTests(TestCase): | ||
|
|
||
| @unittest.skip('should fix html templates') |
There was a problem hiding this comment.
need PDD subtask there to fix every html file in templates
|
|
||
| @unittest.skip('should fix html templates') | ||
| def test_templates(self): | ||
| for dir, _, filenames in os.walk(settings.TEMPLATE_DIR): |
There was a problem hiding this comment.
settings.TEMPLATE_DIR is redundant option, because we'll not redefine it for different envs and django extensions. You can move it to the module level const or just hardcode there.
We try to keep django settings files as small as possible to reduce problems with tuning prod/local envs
There was a problem hiding this comment.
did you mean TEMPLATE_ASSETS_DIR?
There was a problem hiding this comment.
@olegush , y, i meant it, sorry
|
@olegush , approved review, but two minor fixes is left. Implement them plz |
|
|
||
| @unittest.skip('should fix html templates') | ||
| def test_templates(self): | ||
| for dir, _, filenames in os.walk(settings.TEMPLATE_DIR): |
There was a problem hiding this comment.
@olegush , y, i meant it, sorry
| TEMPLATES = [ | ||
| { | ||
| 'BACKEND': 'django.template.backends.django.DjangoTemplates', | ||
| 'DIRS': [TEMPLATE_DIR], | ||
| 'DIRS': [TEMPLATE_DIR, TEMPLATE_ASSETS_DIR], |
Closes #973