Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

catalog.py:209-214: Prevent code doubling in series... #631

Open
0pdd opened this issue Apr 21, 2019 · 3 comments
Open

catalog.py:209-214: Prevent code doubling in series... #631

0pdd opened this issue Apr 21, 2019 · 3 comments
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable Sections Series feature take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 21, 2019

The puzzle 619-70cad134 from #619 has to be resolved:

stroyprombeton/stroyprombeton/views/catalog.py

Lines 209 to 214 in 0b17e23

# @todo #619:60m Prevent code doubling in series views.
# Now series and series_matrix have doubled code.
# Possible solutions:
# - Use only one view for series and series+category. As category page does
# - Use view context system. Category view does it too.
# Those solutions don't except each other.

The puzzle was created by duker33 on 21-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 21, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Apr 21, 2019
@duker33
#622 #619 Series fixes from prod (#628)
0b17e23 
* #622  Fix not shown item names at the search results

* #619  Return 404 for category with no options

* #622  Return 404 for categories with no active options

* #622  Rm redundant CategoryTile tests

* #622  Show mark column at the options list on product page

* #622  Fix test

* #622  Drop unused import

* #622  Fix test
This was referenced Apr 21, 2019
Closed
Closed
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable Series feature take it any teammate can take this issue and start working with it labels Apr 23, 2019
@duker33
Copy link
Contributor

duker33 commented Jul 2, 2019

rm doubling between sections and series too.
Look at views stroyprombeton.views.catalog.sections_matrix and stroyprombeton.views.catalog.section

@duker33 duker33 added 1 burning issue and removed 2 performer can implement issue at his closest convenient time labels Jul 2, 2019
@duker33
Copy link
Contributor

duker33 commented Jul 2, 2019

rm doubling between tests too see stroyprombeton.tests.tests_views.SeriesMatrix

@duker33 duker33 mentioned this issue Jul 2, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable Sections Series feature take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd