Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /rest/catalog/banks #31

Open
Exordian opened this issue Dec 6, 2016 · 1 comment
Open

Support /rest/catalog/banks #31

Exordian opened this issue Dec 6, 2016 · 1 comment

Comments

@Exordian
Copy link

Exordian commented Dec 6, 2016

Currently it is supported to use /rest/catalog/banks/{countryCode}/{bankCode}. Unfortunately this request returns something different when called without parameters (returning all supported banks).

Especially mapping this is real pain since static typed languages normally do not allow you to put different types in the same list. Is there a chance for a server API fix soon? I'd be glad to provide a PR after this is resolved, but I currently don't want to build a custom deserializer to fix this.

"icon":[  
      "https://api.figo.me/assets/images/accounts/bundesbank.png",
      {  
         "120x120":"https://api.figo.me/assets/images/accounts/bundesbank_120.png",
         "144x144":"https://api.figo.me/assets/images/accounts/bundesbank_144.png",
         "192x192":"https://api.figo.me/assets/images/accounts/bundesbank_192.png",
         "256x256":"https://api.figo.me/assets/images/accounts/bundesbank_256.png",
         "48x48":"https://api.figo.me/assets/images/accounts/bundesbank_48.png",
         "60x60":"https://api.figo.me/assets/images/accounts/bundesbank_60.png",
         "72x72":"https://api.figo.me/assets/images/accounts/bundesbank_72.png",
         "84x84":"https://api.figo.me/assets/images/accounts/bundesbank_84.png",
         "96x96":"https://api.figo.me/assets/images/accounts/bundesbank_96.png"
      }
   ]
@berend
Copy link
Contributor

berend commented Mar 28, 2017

Sorry, for replying delayed. We are aware of the differences between one array item of /catalog/banks and the single item of /catalog/banks/<country_code>/<bank_code>. We are trying to solve this, but we must respect some partners, who might break when changing this.

I will keep this open until there we adjusted these endpoint to deliver identical items.

If you are willing to provide PRs before that, we are definitely willing to merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants