Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Include Option for Filename Suffix #74

Open
bitstarr opened this issue Jan 24, 2020 · 2 comments · May be fixed by #85
Open

Include Option for Filename Suffix #74

bitstarr opened this issue Jan 24, 2020 · 2 comments · May be fixed by #85

Comments

@bitstarr
Copy link

bitstarr commented Jan 24, 2020 •
edited
Loading

Currently all subsetted fonts will have a name like originalfilename-subset.woff.
I would love to decide by my own if the -subset suffix is needed and which string it should be.

It seem like it's hard wired at the moment, see https://github.com/filamentgroup/glyphhanger/blob/master/src/GlyphHangerSubset.js#L87
Sadly I'm not that experienced in node.js to provide an accurate pull request.
@zk-phi
Copy link

zk-phi commented Feb 20, 2021 •
edited
Loading

I worked around with this patch: master...zk-phi:master

Note that suffix cannot start with -, since it's treated as an commandline option.

@zk-phi zk-phi linked a pull request Feb 20, 2021 that will close this issue
Open
@zk-phi
Copy link

zk-phi commented Feb 20, 2021

I've just created a PR, but you may also use this patch zk-phi/zk-phi.github.io@1f86c92 with patch-package npm package until it's merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --suffix command-line option zk-phi/glyphhanger
2 participants
@zk-phi @bitstarr