This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
update shelljs to 0.8.4 to fix circular dependency warnings that occur with node.js v14 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pho3nixf1re
approved these changes
Jul 1, 2020
|
Any chance to ^^bump rebasing and merging this? https://www.sarasoueidan.com/blog/glyphhanger/ mentions in their article on a tool, not knowing where it's from. Someone just tweeted it's shelljs, and this same fix. Upstreaming the fix might be better than tweeting patches. |
|
Oh the lock file is not included in the repo. I was just about to make an issue to include it. Looks like it's here. Is that deliberate? Might make rebasing easier to lose it for-now and give guidance on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to node.js v14, running glyphhanger always produces a list of circular dependency warnings. The root cause of these warnings is the shelljs package, and after upgrading this to version 0.8.4 the warnings no longer occur.