Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: genesis preseal: get it working #12132

Merged
merged 4 commits into from
Jun 25, 2024
Merged

fix: genesis preseal: get it working #12132

merged 4 commits into from
Jun 25, 2024

Conversation

aarshkshah1992
Copy link
Contributor

Related Issues

Closes #12121

Need to merge and release Actors and go-state-types before merging this.

filecoin-project/builtin-actors#1553
filecoin-project/go-state-types#276

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link

Some checks haven't completed yet

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approval pending go-state-types release or some other magic to get this into a branch somewhere

@rvagg
Copy link
Member

rvagg commented Jun 25, 2024

I've pushed [email protected] to this

@rvagg rvagg force-pushed the fix/preseal-cspv branch from 353da4a to da0660b Compare June 25, 2024 04:17
@rvagg
Copy link
Member

rvagg commented Jun 25, 2024

This requires #12144 merged into it - that should be reviewed separately and then this branch, with it, can be merged into master

@rvagg
Copy link
Member

rvagg commented Jun 25, 2024

(don't squash merge this, too many unrelated things, rebase merge is good)

plus some code improvement refactoring
@aarshkshah1992 aarshkshah1992 merged commit d9195c4 into master Jun 25, 2024
77 checks passed
@aarshkshah1992 aarshkshah1992 deleted the fix/preseal-cspv branch June 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Enable bootup from genesis (e.g., Butterfly testing)
4 participants