Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log node ids with smart client #35

Merged
merged 8 commits into from
Oct 31, 2023
Merged

feat: log node ids with smart client #35

merged 8 commits into from
Oct 31, 2023

Conversation

AmeanAsad
Copy link
Contributor

Changes:

  • When making requests directly to nodes, we now have the ability to log their ids even if the initial fetch fails without response.

@AmeanAsad AmeanAsad requested a review from guanzo October 30, 2023 22:42
guanzo
guanzo reviewed Oct 30, 2023
View reviewed changes
guanzo
guanzo reviewed Oct 30, 2023
View reviewed changes
guanzo
guanzo reviewed Oct 30, 2023
View reviewed changes
AmeanAsad and others added 3 commits October 30, 2023 18:48
guanzo
guanzo reviewed Oct 30, 2023
View reviewed changes
@AmeanAsad AmeanAsad merged commit 35119d9 into main Oct 31, 2023
@AmeanAsad AmeanAsad deleted the feat/logging-nodeids branch October 31, 2023 00:30
@AmeanAsad AmeanAsad mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanzo guanzo guanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmeanAsad @guanzo