From 215fbc51c38ee449062946fb7dec63584bfef286 Mon Sep 17 00:00:00 2001 From: Priyam Brahmbhatt Date: Tue, 29 Jan 2019 16:39:18 -0500 Subject: [PATCH 1/2] changed the constants in the code to const --- src/filesystem/implementation.js | 50 ++++++++++++++++---------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/filesystem/implementation.js b/src/filesystem/implementation.js index 79275ce8..9dc4cf79 100644 --- a/src/filesystem/implementation.js +++ b/src/filesystem/implementation.js @@ -1,41 +1,41 @@ -var Path = require('../path.js'); +const Path = require('../path.js'); var normalize = Path.normalize; var dirname = Path.dirname; var basename = Path.basename; var isAbsolutePath = Path.isAbsolute; var shared = require('../shared.js'); -var Constants = require('../constants.js'); -var NODE_TYPE_FILE = Constants.NODE_TYPE_FILE; -var NODE_TYPE_DIRECTORY = Constants.NODE_TYPE_DIRECTORY; -var NODE_TYPE_SYMBOLIC_LINK = Constants.NODE_TYPE_SYMBOLIC_LINK; -var NODE_TYPE_META = Constants.NODE_TYPE_META; +const Constants = require('../constants.js'); +const NODE_TYPE_FILE = Constants.NODE_TYPE_FILE; +const NODE_TYPE_DIRECTORY = Constants.NODE_TYPE_DIRECTORY; +const NODE_TYPE_SYMBOLIC_LINK = Constants.NODE_TYPE_SYMBOLIC_LINK; +const NODE_TYPE_META = Constants.NODE_TYPE_META; -var FULL_READ_WRITE_EXEC_PERMISSIONS = Constants.FULL_READ_WRITE_EXEC_PERMISSIONS; +const FULL_READ_WRITE_EXEC_PERMISSIONS = Constants.FULL_READ_WRITE_EXEC_PERMISSIONS; -var ROOT_DIRECTORY_NAME = Constants.ROOT_DIRECTORY_NAME; -var SUPER_NODE_ID = Constants.SUPER_NODE_ID; -var SYMLOOP_MAX = Constants.SYMLOOP_MAX; +const ROOT_DIRECTORY_NAME = Constants.ROOT_DIRECTORY_NAME; +const SUPER_NODE_ID = Constants.SUPER_NODE_ID; +const SYMLOOP_MAX = Constants.SYMLOOP_MAX; -var O_READ = Constants.O_READ; -var O_WRITE = Constants.O_WRITE; -var O_CREATE = Constants.O_CREATE; -var O_EXCLUSIVE = Constants.O_EXCLUSIVE; -var O_APPEND = Constants.O_APPEND; -var O_FLAGS = Constants.O_FLAGS; +const O_READ = Constants.O_READ; +const O_WRITE = Constants.O_WRITE; +const O_CREATE = Constants.O_CREATE; +const O_EXCLUSIVE = Constants.O_EXCLUSIVE; +const O_APPEND = Constants.O_APPEND; +const O_FLAGS = Constants.O_FLAGS; -var XATTR_CREATE = Constants.XATTR_CREATE; -var XATTR_REPLACE = Constants.XATTR_REPLACE; -var FS_NOMTIME = Constants.FS_NOMTIME; -var FS_NOCTIME = Constants.FS_NOCTIME; +const XATTR_CREATE = Constants.XATTR_CREATE; +const XATTR_REPLACE = Constants.XATTR_REPLACE; +const FS_NOMTIME = Constants.FS_NOMTIME; +const FS_NOCTIME = Constants.FS_NOCTIME; -var Errors = require('../errors.js'); -var DirectoryEntry = require('../directory-entry.js'); +const Errors = require('../errors.js'); +const DirectoryEntry = require('../directory-entry.js'); var openFiles = require('../open-files.js'); var OpenFileDescription = require('../open-file-description.js'); -var SuperNode = require('../super-node.js'); -var Node = require('../node.js'); -var Stats = require('../stats.js'); +const SuperNode = require('../super-node.js'); +const Node = require('../node.js'); +const Stats = require('../stats.js'); /** * Update node times. Only passed times are modified (undefined times are ignored) From 491104b0c502f094276ff6cf4d936dbed2e7bbc2 Mon Sep 17 00:00:00 2001 From: Priyam Brahmbhatt Date: Tue, 29 Jan 2019 17:22:42 -0500 Subject: [PATCH 2/2] installed npm for the tests --- package-lock.json | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index f699b11d..2b9408b1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5307,12 +5307,14 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -5327,17 +5329,20 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -5454,7 +5459,8 @@ "inherits": { "version": "2.0.3", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -5466,6 +5472,7 @@ "version": "1.0.0", "bundled": true, "dev": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -5480,6 +5487,7 @@ "version": "3.0.4", "bundled": true, "dev": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -5487,12 +5495,14 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "minipass": { "version": "2.2.4", "bundled": true, "dev": true, + "optional": true, "requires": { "safe-buffer": "^5.1.1", "yallist": "^3.0.0" @@ -5511,6 +5521,7 @@ "version": "0.5.1", "bundled": true, "dev": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -5591,7 +5602,8 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -5603,6 +5615,7 @@ "version": "1.4.0", "bundled": true, "dev": true, + "optional": true, "requires": { "wrappy": "1" } @@ -5724,6 +5737,7 @@ "version": "1.0.2", "bundled": true, "dev": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0",