Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hide empty drives without attached media #16426

Open
Lamparter opened this issue Nov 2, 2024 · 7 comments
Open

Feature: Hide empty drives without attached media #16426

Lamparter opened this issue Nov 2, 2024 · 7 comments

Comments

@Lamparter
Copy link
Contributor

Lamparter commented Nov 2, 2024

Description

Recently I plugged in an SD card reader extension in to my computer. It comes with multiple SD card slots (MMC, microSD, SDHC, xD etc.) and so plugging it in creates a new disk interface in Disk Management.

diskmgmt.mmc

These drives (F:, H:, I:, J:) are hidden in File Explorer automatically, which makes sense considering there is no data inside them and the SD card reader extension has nothing plugged into it.

explorer.exe

However, in Files they display on the homepage and in the sidebar.

Files.App.exe

Trying to open these drives results in an access denied error. This error is not logged.

Image

Steps To Reproduce

  1. Plug in a drive with no media attached
  2. See the drive appear in Files

Requirements

  • Detect drives that have no media
  • Remove them from the interface

Files Version

3.7.11.0

Windows Version

10.0.22631.4391

User ID

0b679509-8cd1-45cb-8f30-b5fd16be82cc

Log File

View full log contents
2024-11-02 17:30:30.2403|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-11-02 17:30:30.8119|Information|Adding cloud provider "Creative Cloud" mapped to {0}
2024-11-02 17:30:31.1306|Information|Drive added: C:\, Fixed
2024-11-02 17:30:31.1731|Information|Drive added: D:\, Fixed
2024-11-02 17:30:31.3555|Information|Drive added: E:\, Fixed
2024-11-02 17:30:31.3734|Warning|Unauthorized: Attempting to add the device, F:\, failed at the StorageFolder initialization step. This device will be ignored.
2024-11-02 17:30:31.4069|Information|Drive added: G:\, Removable
2024-11-02 17:30:31.4267|Warning|Unauthorized: Attempting to add the device, H:\, failed at the StorageFolder initialization step. This device will be ignored.
2024-11-02 17:30:31.4356|Warning|Unauthorized: Attempting to add the device, I:\, failed at the StorageFolder initialization step. This device will be ignored.
2024-11-02 17:30:31.4664|Warning|Unauthorized: Attempting to add the device, J:\, failed at the StorageFolder initialization step. This device will be ignored.
2024-11-02 17:30:31.4884|Information|Adding cloud provider "OneDrive" mapped to D:\OneDrive
2024-11-02 17:30:31.4932|Information|Drive added: Z:\, Network
2024-11-02 17:30:31.5580|Information|Drive added: G:\
2024-11-02 17:30:31.5670|Information|Drive added: J:\
2024-11-02 17:30:31.5787|Information|Drive added: I:\
2024-11-02 17:30:31.5908|Information|Drive added: F:\
2024-11-02 17:30:31.6022|Information|Drive added: H:\
2024-11-02 17:30:31.6069|Information|Adding cloud provider "OneDrive - {0}" mapped to D:\OneDrive - {0}
2024-11-02 17:30:31.3734 | Warning | Unauthorized: Attempting to add the device, "F:\", failed at the StorageFolder initialization step; this device will be ignored.
2024-11-02 17:30:31.4267 | Warning | Unauthorized: Attempting to add the device, "H:\", failed at the StorageFolder initialization step; this device will be ignored.
2024-11-02 17:30:31.4356 | Warning | Unauthorized: Attempting to add the device, "I:\", failed at the StorageFolder initialization step; this device will be ignored.
2024-11-02 17:30:31.4664 | Warning | Unauthorized: Attempting to add the device, "J:\", failed at the StorageFolder initialization step; the device will be ignored.

There is a high chance that this issue has already been reported, though I couldn't find anything similar while searching.

@Josh65-2201
Copy link
Member

Josh65-2201 commented Nov 2, 2024

It was decided a while ago to not hide them #9170 (comment)

@Lamparter
Copy link
Contributor Author

That's a ridiculous choice since they see essentially useless being there as they lead to an error. Perhaps making the tile appear disabled would useful in this case.

@0x5bfa
Copy link
Member

0x5bfa commented Nov 3, 2024

In fact, it's confusing while these removable media don't have physical storage space (it's not the case for DVD drive). @Lamparter Can you access these hidden drives from address bar in File Explorer?

@yaira2
Copy link
Member

yaira2 commented Nov 3, 2024

If there is enough interest in changing the behavior, I'm not against making this change.

@yaira2 yaira2 changed the title Bug: Drives with no media attached show in Files Feature: Hide empty drives without attached media Nov 3, 2024
@Lamparter
Copy link
Contributor Author

@yaira2 would you like to move forward with this? Perhaps you could create a poll in the server if it isn't going too far.

@Lamparter
Copy link
Contributor Author

Can you access these hidden drives from address bar in File Explorer?

@0x5bfa sorry, I didn't see your question!

This little dialogue appears when typing in the drive letter.
Image

Perhaps it might be good if a smaller drive widget appears in the drive section with an "insert media" label and a similar dialogue appearing when clicked.

@yaira2
Copy link
Member

yaira2 commented Dec 8, 2024

@yaira2 would you like to move forward with this? Perhaps you could create a poll in the server if it isn't going too far.

Let's move forward with this.

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready to build
Development

No branches or pull requests

4 participants