Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Refresh Details Layout Columns after changing setting #13747

Open
Quietbeat opened this issue Nov 8, 2023 · 5 comments · May be fixed by #16512
Open

Feature: Refresh Details Layout Columns after changing setting #13747

Quietbeat opened this issue Nov 8, 2023 · 5 comments · May be fixed by #16512

Comments

@Quietbeat
Copy link

What feature or improvement do you think would benefit Files?

I originally raised defect #13741 so here's the requested Feature Request.

By default, the 'Tag' column is shown and when turning off 'Tag column', I don't see the 'Tag' column removed nor is it removed when I close the Settings dialog.

image

Requirements

  1. Open Files
  2. Open Details Layout Columns
  3. Turn off 'Tag' column

Files Version

3.0

Windows Version

22H2 Build 22621.2506

Comments

No response
@yaira2 yaira2 changed the title Details Layout Columns refresh issue Feature: Refresh Details Layout Columns after changing setting Nov 8, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 8, 2023

Thanks for the feedback

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Nov 8, 2023
@yaira2 yaira2 mentioned this issue Jan 29, 2024
Closed
@ferrariofilippo
Copy link
Contributor

ferrariofilippo commented Nov 23, 2024 •
edited
Loading

I'm not sure how this settings is supposed to work.
Turning off a column should hide it in ALL the folders, overriding Individual Folder Preferences? Should it do so only if Sync layout ... is enabled?
If layouts are not synced, should it affect only folders without a preference (default preferences)?
If a column is turned off from the settings, should the user be able to toggle it using the context flyout?

@Josh65-2201
Copy link
Member

The settings are for default columns, if the sync toggle is on then it should apply to all like now and refresh the open tabs, if not do nothing different then right now. It shouldn't change anything with the context menu toggles.

@ferrariofilippo ferrariofilippo linked a pull request Nov 23, 2024 that will close this issue
Open
@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Nov 23, 2024
@yaira2
Copy link
Member

yaira2 commented Nov 23, 2024

if the sync toggle is on then it should apply to all like now and refresh the open tabs

This feature isn't limited to when the 'sync folder options' setting is enabled. It should also apply to any tab where the folder preferences weren't overridden.

@ferrariofilippo
Copy link
Contributor

This feature isn't limited to when the 'sync folder options' setting is enabled. It should also apply to any tab where the folder preferences weren't overridden.

The PR I opened should already support this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Files task board
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Refresh Details Layout Columns after changing setting ferrariofilippo/Files
4 participants
@Josh65-2201 @yaira2 @Quietbeat @ferrariofilippo