Code Quality: Upgrade dependencies #16741
Conversation
|
I temporarily brought back the sln for CI. |
|
CI is passing |
|
By the way, the work you put into this is amazing and the fact that it works is jaw-dropping 😮 |
This reverts commit 747dc7e.
|
⛔ No XAML files changed. |
src/Files.App.Controls/AdaptiveGridView/AdaptiveGridView.Properties.cs
Outdated
Show resolved
Hide resolved
src/Files.App/ViewModels/UserControls/Previews/ShellPreviewViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
What if you created a WindowsTargetFramework MSBuild switch so you don't need to specify $(TargetFrameworkVersion)-windows$(TargetWindowsVersion) in every project file?
e.g.:
<!-- Directory.Build.props -->
<WindowsTargetFramework>$(TargetFrameworkVersion)-windows$(TargetWindowsVersion)</WindowsTargetFramework>and then in the project file:
<!-- Files.*.csproj, Target: Windows -->
<TargetFramework>$(WindowsTargetFramework)</TargetFramework>
| <TargetFrameworkVersion>net9.0</TargetFrameworkVersion> | ||
| <TargetWindowsVersion>10.0.22621.0</TargetWindowsVersion> | ||
| <MinimalWindowsVersion>10.0.19041.0</MinimalWindowsVersion> | ||
| <WindowsSdkPackageVersion>10.0.22621.57</WindowsSdkPackageVersion> |
There was a problem hiding this comment.
| <WindowsSdkPackageVersion>10.0.22621.57</WindowsSdkPackageVersion> | |
| <WindowsSdkPackageVersion>10.0.22621.57</WindowsSdkPackageVersion> | |
| <DefineConstants>$(DefineConstants);$(Platform)</DefineConstants> |
|
I won't request changes for tiny quality and sanitization issues as long as it works (and looks perfect already) in this PR given lots of work have been put and it still WIP. |
|
Wait, this PR is WIP? |
It's not WIP. Some missing features like mouse middle-button scrolling will be ported in the following PR. |
|
Yet, I don't request any. |
Co-authored-by: Lamparter <[email protected]> Signed-off-by: Steve <[email protected]>
|
I think I have resolved most feedbacks. PTAL. |
Upgrade to .NET 9
Upgrade to WASDK 1.6
Upgrade to CommunityToolkit.WinUI 8.2
Upgrade to CsWinRT 2.2
Migrate to slnx (while still keeping sln for CI now)
Use centralized nuget package version management
Use new Microsoft.UI.Content metadata
Known issues:
Resolved / Related Issues
Supersedes #16156
Supersedes #16557
Closes #14826
Closes #16705
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.