Modified to hanlde read path errors #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velvia
reviewed
Mar 27, 2017
| import filodb.core._ | ||
| import monix.reactive.Observable |
There was a problem hiding this comment.
Can you put the monix import in the first section with everything else? The order should be:
everything non-filo
internal filodb
|
Travis failed earlier build for the following reason: |
velvia
approved these changes
Mar 29, 2017
velvia
pushed a commit
that referenced
this pull request
Oct 1, 2018
…or, and truncate error handling (#145) * fix(cassandra): Fix java.lang.IllegalArgumentException Buffer cannot be null when getting null buffers from C* * fix(core,coordinator): Properly wait for and pass errors from truncate() all the way up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No error is displayed when cassandra nodes are down for read path #120