fix(query): override RemoteExec::doExecute instead of execute() #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextheimer
commented
Dec 9, 2022
Comment on lines
-170
to
-176
| case QueryResult(id, _, response, _, _, _) => { | ||
| val rv = response(0) | ||
| rv.rows.size shouldEqual 0 | ||
| rv.rows.map { row => | ||
| val record = row.asInstanceOf[BinaryRecordRowReader] | ||
| rv.asInstanceOf[SerializedRangeVector].schema.toStringPairs(record.recordBase, record.recordOffset) | ||
| } |
There was a problem hiding this comment.
Sketched out by this-- @sherali42 , do we need the result to contain an empty RV?
|
What requires this change? Currently since execute is overridden, no RVTs are applied. How do we ensure now that the transformation is not applied twice? Once on remote side and once locally after the response from remote partition is received? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Currently,
RemoteExecplans override the usualexecutelogic; this means that common tasks likeRangeVectorTransformerapplication will be missed if they are not explicitly performed in the overriddenexecute.This PR moves the overridden logic into
doExecute, so all commonexecutetasks will be performed automatically.