fix(query): pushdown joins only if lhs/rhs shard keys are identical #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case _ => None | ||
| } | ||
| val tsFunc = tsp.targetSchemaFunc(filters.head) | ||
| startEndMsPairOpt match { |
There was a problem hiding this comment.
startEndMsPairOpt.map() is cleaner than pattern match that return None for None
| case _ => None | ||
| } | ||
| } | ||
| val tsLabels: Option[Seq[String]] = getTargetSchemaLabelsFromRawSeries(rs, qContext) |
There was a problem hiding this comment.
Why a method? This lead to code duplication and doing map instead of pattern match will be concise as well
| val rhsData = helper(bj.rhs) | ||
| val canPushdown = lhsData.isDefined && rhsData.isDefined && { | ||
| val hasScalar = lhsData.get.shards.isEmpty || rhsData.get.shards.isEmpty | ||
| val canPushdownJoin = lhsData.get.shards == rhsData.get.shards && |
There was a problem hiding this comment.
Is the order of Seq containing shards granted to be ordered consistently? Seq(1, 2, 3) != Seq(3, 2, 1) though you want to push down.
Also too much going on here, some comments would really be helpful to understand the intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Currently, queries such as:
will be pushed down because planner logic only requires that the join operands have target-schemas defined against the same set of labels.
This PR adds logic to also require that shard keys are identical on each side of the join.