bug(coord): Adding ApplyLimitFunction support for cross-partition query routing #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-shipit
reviewed
Sep 9, 2024
| @@ -209,6 +209,12 @@ object LogicalPlanParser { | |||
| }$ClosingCurlyBraces" | |||
| } | |||
|
|
|||
| private def applyLimitToQuery(lp: ApplyLimitFunction): String = { | |||
| val periodicSeriesQuery = convertToQuery(lp.vectors) | |||
| s"$periodicSeriesQuery limit ${lp.limit}" | |||
There was a problem hiding this comment.
Just curious if limit 1 will return 1 time series or 2 time series at the end if we have two partition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
When query is routed to different partition for multi-ns queries, we see this type of error
This PR fixes the logical plan to query translation and also removes the default handler.