Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query) extend @modifier to longtime and multi-partition queries. #1837

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yu-shipit
Copy link
Contributor

@yu-shipit yu-shipit commented Aug 19, 2024

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :
@modidier does not work for multi-partition and longtime planner

New behavior :
@modidier supports for multi-partition and longtime planner
Consider a query like
(foo @end()) unless last_over_time(foo[1h])
The previous plan would be like

-StitchExec
--Unless
---foo@end()  @P1-downsample. // do not have the data
---last_over_time(foo[1h])   @P1-downsample
--Unless
---foo@end()  @P1-raw
---last_over_time(foo[1h])    @P1-raw
--Unless
---foo@end()  @P2-raw

The new plan would be like

-Unless
--RepeatedTransformer
---foo@end()  @P2-raw
-StitchExec
---last_over_time(foo[1h])   @P1-downsample
---last_over_time(foo[1h])    @P1-raw
---last_over_time(foo[1h])    @P2-raw

Caveat!
Window that spans multi-clusters may not work. For example, these may not work.

last_over_time(foo[7d])
(foo @end()) unless last_over_time(foo[7d])

BREAKING CHANGES

If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.

Breaking changes may include:

  • Any schema changes to any Cassandra tables
  • The serialized format for Dataset and Column (see .toString methods)
  • Over the wire formats for Akka messages / case classes
  • Changes to the HTTP public API
  • Changes to query parsing / PromQL parsing

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant