Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finch.jlregressions #644

Closed
hameerabbasi opened this issue Nov 19, 2024 · 2 comments · Fixed by pydata/sparse#812
Closed

Finch.jlregressions #644

hameerabbasi opened this issue Nov 19, 2024 · 2 comments · Fixed by pydata/sparse#812

Comments

@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Nov 19, 2024

Failures can be seen starting at: https://github.com/pydata/sparse/actions/runs/11897897564/job/33153177355?pr=809#step:5:12261

The common theme seems to be:

juliacall.JuliaError: Finch.FinchProtocolError("SparseCOOLevels cannot be updated multiple times")

cc @willow-ahrens

@willow-ahrens
Copy link
Collaborator

The issue is:

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../../micromamba/envs/sparse-dev/lib/python3.10/site-packages/scipy/sparse/linalg/_matfuncs.py:75: in inv
    I = _ident_like(A)
../../../micromamba/envs/sparse-dev/lib/python3.10/site-packages/scipy/sparse/linalg/_expm_multiply.py:102: in _ident_like
    return sparse.eye(A.shape[0], A.shape[1], dtype=A.dtype)
../../../micromamba/envs/sparse-dev/lib/python3.10/site-packages/finch/tensor.py:1022: in eye
    jl.seval(f"""
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = Julia: Main
expr = '\n        @finch begin\n            tns .= 0\n            for i=_, j=_\n                if i+0 == j\n                    tns[i, j] += 1\n                end\n            end\n        end\n    '

which was fixed in finch-tensor-python on main:

https://github.com/finch-tensor/finch-tensor-python/blob/0e92056eb38514a1e95d01deab297f878457a576/src/finch/tensor.py#L1022-L1031

Do I need to publish a new version?

@willow-ahrens
Copy link
Collaborator

fixed in pydata/sparse#812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants