Merge pull request #90 from findify/analytics-fix

analytics fix
findify · Jul 22, 2024 · 93c2c88 · 93c2c88
2 parents 3ef6432 + 21d6495
commit 93c2c88
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 15 deletions.
diff --git a/assets/findify-analytics.js b/assets/findify-analytics.js
@@ -3,6 +3,7 @@
    * productPageAnalyticsTagSelectorId can be found in findify-head-injector
    */
   const productPageAnalyticsTagSelectorId = 'findify-analytics-product';
+
   const isProductDetails = () =>
     !!document.getElementById(productPageAnalyticsTagSelectorId);
 
@@ -18,21 +19,50 @@
     const ref = window.document.referrer;
     const url = window.location.href;
     const page_type = getPageType();
+    const itemId = document
+      .getElementById(productPageAnalyticsTagSelectorId)
+      ?.getAttribute('data-findify-item-id');
+    const variantId = document
+      .getElementById(productPageAnalyticsTagSelectorId)
+      ?.getAttribute('data-findify-variant-item-id');
+
+    const sendEvent = (...props) =>
+      findify.core.analytics.sendEvent('view-page', ...props);
 
     try {
-      findify.core.analytics.sendEvent('view-page', {
+      sendEvent({
         width,
         height,
         ref,
         url,
         page_type,
+        item_id: itemId,
+        variant_item_id: variantId,
       });
     } catch (error) {
       console.error('Error sending view-page event', error);
     }
   };
 
-  const updateCartEvent = () => {};
+  const updateCartEvent = () => {
+    const cart = document.querySelector('[data-findify-event="update-cart"]');
+    const cartItems = cart && Array.prototype.slice.call(cart.children);
+    const items =
+      cartItems.map((item) => {
+        return {
+          item_id: item.getAttribute('data-findify-item-id'),
+          variant_item_id: item.getAttribute('data-findify-variant-item-id'),
+          unit_price: item.getAttribute('data-findify-unit-price'),
+          quantity: item.getAttribute('data-findify-quantity'),
+        };
+      }) || [];
+
+    try {
+      findify.core.analytics.sendEvent('update-cart', { line_items: items });
+    } catch (error) {
+      console.error('Error sending update-cart event', error);
+    }
+  };
 
   findify.core.init.then(() => {
     viewPageEvent();

diff --git a/assets/findify-product-card.js b/assets/findify-product-card.js
@@ -30,7 +30,7 @@ const savePosition = (id, page) => {
 }
 
 const initOnProductCardClick = (id, page, properties) => {
-  document.getElementById(id).addEventListener("click", (e) => {
+  document.querySelector(`.${properties.widget}_${id}`).addEventListener("click", (e) => {
     initProductCardAnalytics(id, properties);
     savePosition(id, page);
   });

diff --git a/sections/findify-product-card.liquid b/sections/findify-product-card.liquid
@@ -3,7 +3,7 @@
 <div 
   id="{{ id }}"
   product-id="product-{{ id }}" 
-  class="findify-product-card {{ class }}" 
+  class="findify-product-card {{ class }} {{ widget }}_{{ id }}"
   {%if page != blank%}
     page="{{ page }}"
   {%endif%}

diff --git a/snippets/findify-head-injector.liquid b/snippets/findify-head-injector.liquid
@@ -6,17 +6,16 @@
     data-findify-variant-item-id="{{product.selected_or_first_available_variant.id}}"></div>
 {% endif %}
 
-{% if cart %}
-  <div data-findify-event="update-cart">
-    {% for item in cart.items %}
-      <div
-        data-findify-item-id="{{ item.product_id }}"
-        data-findify-variant-item-id="{{item.variant_id}}"
-        data-findify-unit-price="{{ item.price | money_without_currency }}"
-        data-findify-quantity="{{ item.quantity }}"></div>
-    {% endfor %}
-  </div>
-{% endif %}
+
+<div data-findify-event="update-cart">
+  {% for item in cart.items %}
+    <div
+      data-findify-item-id="{{ item.product_id }}"
+      data-findify-variant-item-id="{{item.variant_id}}"
+      data-findify-unit-price="{{ item.price | money_without_currency }}"
+      data-findify-quantity="{{ item.quantity }}"></div>
+  {% endfor %}
+</div>
 
 <script>
   window.findify = {