Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6, SwiftUnicodeDataTables, Other Improvements #106

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

STREGA
Copy link
Contributor

@STREGA STREGA commented Nov 22, 2024

Moves the package to Swift 6 and the Package tools version to swift 6.
Since Embedded is only available using Swift 6 toolchain, it only seems logical to require the baseline language version.

Also moves the helper variables to the bottom of Package.swift and converts them to computed variables.
When the helper variables are constants they can be filled in before the Context.environment is populated leading to compile errors. This change will help reduce build errors when users copy the variables from PlaydateKit to their own package.

@STREGA STREGA marked this pull request as draft November 22, 2024 20:43
@STREGA
Copy link
Contributor Author

STREGA commented Nov 23, 2024

Added support for linking SwiftUnicodeDataTables.
In my testing the compiled pdx is the same size as when linked and not linked, when not using any functions that requires the unicode stuff. So this linking is on by default, but a new argument --disableSwiftUnicodeDataTables is added just in case there's a problem in the future. The fix is kind of a hack so the Playdate SDK changing could break the hack.

@STREGA STREGA changed the title Require Swift 6 and tools v6 Swift 6, SwiftUnicodeDataTables, Other Improvements Nov 23, 2024
@STREGA
Copy link
Contributor Author

STREGA commented Nov 23, 2024

Use the plugins PlaydateSDK path for pdc CLI
Show the build path in output to make finding it easier for users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant