chore(analytics): add Scarf to npm install, docs, and ui #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@aviaviavi - thanks for the PR ❤️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 57.34% 57.34%
=======================================
Files 46 46
Lines 1594 1594
=======================================
Hits 914 914
Misses 680 680 ☔ View full report in Codecov by Sentry. |
|
@aviaviavi - are you able to resolve the merge conflict? Apologies! |
|
@maoo - would be keen to get your thoughts here before we merge 👍 |
|
conflicts resolved! |
|
@JamieSlome let me know if I can answer any questions here! |
|
Hey @aviaviavi, could you email me any relevant documentation or agreements regarding how the data gathered by Scarf will be handled? I'll bring that to the TOC to propose approval for FINOS project adoption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @JamieSlome directly, this PR adds basic usage tracking tooling with Scarf, compliant with CNCF guidelines.
There are a few code-level modifications in this PR:
As with all Scarf-based tracking, these metrics are fully anonymized and GDPR-compliant. No PII is being retained or exposed from this change.
I have the organization for git-proxy set up in Scarf, @JamieSlome as soon as you make an account I can transfer org ownership to you, and you'll be able to add any and all project maintainers.