This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Use notification v1 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed a crash. Fix bug with useNotification so that if a child window is open when the notification is launched, the notification is modified, not the child window. Refactor getChildWindows helper to only deal with getting the child windows, no longer in choosing the correct one. This means that it can be used for both useNotification and useChildWindow.
oriondean
suggested changes
Mar 2, 2020
|
|
||
| await Promise.all( | ||
| childWindows.map((win) => | ||
| win.identity.name && win.identity.name === name |
There was a problem hiding this comment.
Do we still need this name check?
…sed a crash, by making reset function async
oriondean
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Related to #11