Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Specific Error Reasons from the VVP API #171

Open
austince opened this issue Aug 28, 2020 · 0 comments
Open

Log Specific Error Reasons from the VVP API #171

austince opened this issue Aug 28, 2020 · 0 comments
Labels
kind/feature New feature or request size/small A small-ish project status/help-wanted Extra attention is needed
Milestone

Comments

@austince
Copy link
Contributor

Currently, errors coming from requests to the VVP API are logged with their HTTP reason and message. The message can be vague and not enough information to track down the root issue.

Describe the solution you'd like

There are more fields available on the error response objects, such as the .errors array. We should ensure that array is marshalled if available and include the messages in the error log.

{

  "kind": "ApiValidationException",
  "apiVersion": "v1",
  "message": "Deployment parameters are invalid",
  "reason": "BadRequest",
  "errors": [
    {
      "attribute": "spec.template.spec.resources[taskmanager].memory",
      "message": "must be >= 1000m",
      "reason": "isLower"
    }
  ],
  "statusCode": 400
}
@austince austince added status/help-wanted Extra attention is needed size/small A small-ish project kind/feature New feature or request labels Aug 28, 2020
@austince austince added this to the v1 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/small A small-ish project status/help-wanted Extra attention is needed
Development

No branches or pull requests

1 participant