Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to manage multiple ververica instances #205

Open
uberspot opened this issue Dec 17, 2020 · 0 comments
Open

Add support to manage multiple ververica instances #205

uberspot opened this issue Dec 17, 2020 · 0 comments
Labels
kind/feature New feature or request

Comments

@uberspot
Copy link

uberspot commented Dec 17, 2020

Hello,

First off, nice project!
I tried a sample deployment of it and it works nicely for one instance. Would it be possible to adjust the operator so it works/calls the api of multiple ververica instances depending on the namespace the custom resources are deployed in?

Describe the solution you'd like

Currently the deployment pattern for this operator assumes only one instance is going to be managed by it. The --vvp-url expects one value and the api token env vars will most likely point to only one value as well.
Would it be possible to add a new parameter/change the existing one so multiple instances can be managed by this operator?
I imagine you'd have to 1) accept multiple urls to manage as an argument, 2) accept their version type (community/enterprise) and 3) an optional token per instance configured? This could be easily parsed from a config file perhaps.

The other bit that might be confusing is, if a VpDeployment shows up in a namespace, which ververica instance would that be deployed too? The easiest path forwards could be just deploy to the instance that lives in the same namespace as the custom resource?

Describe alternatives you've considered

I've also considered deploying this operator multiple times (once per instance of ververica) but that would entail modifying the CRD group.name per instance so they don't conflict and set the webhook.servicename to the name of each operator deployed. And then recompiling the operator each time to change the hardcoded group name in the code. OR set that group name as a flag that can be changed? It seems like a hack though and having one operator for all instances would be ideal.

What do you think?

@uberspot uberspot added the kind/feature New feature or request label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Development

No branches or pull requests

1 participant