From f791dc5207b857d89f586c7314240084a706913a Mon Sep 17 00:00:00 2001 From: Chris Thompson Date: Mon, 10 Oct 2022 00:00:13 -0700 Subject: [PATCH 1/4] Update the firebase.json emulators config to include explicit hosts rather than relying on the default localhost. This fixes some connection issues with unit tests. --- codelab-final-state/firebase.json | 12 ++++++++++++ codelab-initial-state/firebase.json | 12 ++++++++++++ 2 files changed, 24 insertions(+) diff --git a/codelab-final-state/firebase.json b/codelab-final-state/firebase.json index 9ae9582..a8a4a1c 100644 --- a/codelab-final-state/firebase.json +++ b/codelab-final-state/firebase.json @@ -16,16 +16,28 @@ }, "emulators": { "auth": { + "host": "127.0.0.1", "port": 9099 }, "functions": { + "host": "127.0.0.1", "port": 5001 }, "firestore": { + "host": "127.0.0.1", "port": 8080 }, "hosting": { + "host": "127.0.0.1", "port": 5000 + }, + "hub": { + "host": "127.0.0.1", + "port": 4400 + }, + "ui": { + "host": "127.0.0.1", + "port": 4000 } } } diff --git a/codelab-initial-state/firebase.json b/codelab-initial-state/firebase.json index 9ae9582..a8a4a1c 100644 --- a/codelab-initial-state/firebase.json +++ b/codelab-initial-state/firebase.json @@ -16,16 +16,28 @@ }, "emulators": { "auth": { + "host": "127.0.0.1", "port": 9099 }, "functions": { + "host": "127.0.0.1", "port": 5001 }, "firestore": { + "host": "127.0.0.1", "port": 8080 }, "hosting": { + "host": "127.0.0.1", "port": 5000 + }, + "hub": { + "host": "127.0.0.1", + "port": 4400 + }, + "ui": { + "host": "127.0.0.1", + "port": 4000 } } } From a61078ad4aba00f13642b1a3240c021c46972705 Mon Sep 17 00:00:00 2001 From: Chris Thompson Date: Mon, 10 Oct 2022 00:29:46 -0700 Subject: [PATCH 2/4] Bump the node version to 16 from 12. --- .github/workflows/firebase-ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/firebase-ci.yaml b/.github/workflows/firebase-ci.yaml index 958f025..3ef6dc5 100644 --- a/.github/workflows/firebase-ci.yaml +++ b/.github/workflows/firebase-ci.yaml @@ -7,7 +7,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v1 with: - node-version: "12" + node-version: "16" - name: Install Firebase Emulator Suite run: npm install -g firebase-tools - name: Install dependencies From 45d783c52243c0ad449181c01b82d037deb95f2c Mon Sep 17 00:00:00 2001 From: Chris Thompson Date: Mon, 10 Oct 2022 16:12:49 -0700 Subject: [PATCH 3/4] Revert firebase.json changes. --- codelab-final-state/firebase.json | 12 ------------ codelab-initial-state/firebase.json | 12 ------------ 2 files changed, 24 deletions(-) diff --git a/codelab-final-state/firebase.json b/codelab-final-state/firebase.json index a8a4a1c..9ae9582 100644 --- a/codelab-final-state/firebase.json +++ b/codelab-final-state/firebase.json @@ -16,28 +16,16 @@ }, "emulators": { "auth": { - "host": "127.0.0.1", "port": 9099 }, "functions": { - "host": "127.0.0.1", "port": 5001 }, "firestore": { - "host": "127.0.0.1", "port": 8080 }, "hosting": { - "host": "127.0.0.1", "port": 5000 - }, - "hub": { - "host": "127.0.0.1", - "port": 4400 - }, - "ui": { - "host": "127.0.0.1", - "port": 4000 } } } diff --git a/codelab-initial-state/firebase.json b/codelab-initial-state/firebase.json index a8a4a1c..9ae9582 100644 --- a/codelab-initial-state/firebase.json +++ b/codelab-initial-state/firebase.json @@ -16,28 +16,16 @@ }, "emulators": { "auth": { - "host": "127.0.0.1", "port": 9099 }, "functions": { - "host": "127.0.0.1", "port": 5001 }, "firestore": { - "host": "127.0.0.1", "port": 8080 }, "hosting": { - "host": "127.0.0.1", "port": 5000 - }, - "hub": { - "host": "127.0.0.1", - "port": 4400 - }, - "ui": { - "host": "127.0.0.1", - "port": 4000 } } } From 0c18c138fe9159fced931ff3c05e052d96585d95 Mon Sep 17 00:00:00 2001 From: Chris Thompson Date: Mon, 10 Oct 2022 16:27:42 -0700 Subject: [PATCH 4/4] Engine updates --- codelab-final-state/functions/package.json | 2 +- codelab-initial-state/functions/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/codelab-final-state/functions/package.json b/codelab-final-state/functions/package.json index ca2e2f8..89764b5 100644 --- a/codelab-final-state/functions/package.json +++ b/codelab-final-state/functions/package.json @@ -11,7 +11,7 @@ "test": "mocha --timeout 5000 --exit" }, "engines": { - "node": "10" + "node": "16" }, "dependencies": { "file-system": "^2.2.2", diff --git a/codelab-initial-state/functions/package.json b/codelab-initial-state/functions/package.json index ca2e2f8..89764b5 100644 --- a/codelab-initial-state/functions/package.json +++ b/codelab-initial-state/functions/package.json @@ -11,7 +11,7 @@ "test": "mocha --timeout 5000 --exit" }, "engines": { - "node": "10" + "node": "16" }, "dependencies": { "file-system": "^2.2.2",