Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] generate configuration is a generic map when using DevUI model prompt view #2046

Open
hugoaguirre opened this issue Feb 20, 2025 · 0 comments
Labels
bug Something isn't working go

Comments

@hugoaguirre
Copy link
Contributor

hugoaguirre commented Feb 20, 2025

Describe the bug
When using DevUI in the Model view, users can tune model configuration for the generate request call.

When tracing down the request configuration in Genkit plugins, we realized the request configuration comes as a map[string]any instead of the expected type (ai.GenerationCommonConfig) causing the request not to be properly configured in the plugin.

Here's where the bug resides (this is just for gemini plugin but other plugins might be affected):
https://github.com/firebase/genkit/blob/main/go/plugins/googleai/googleai.go#L325

To Reproduce
Use DevUI to send a request, configuration made in the view won't take effect on the request

Expected behavior
Genkit generate call should be configured based on user inputs

Screenshots
Create a debug print for the else branch
Image

Execute the Generate call using DevUI and go back to the logs, the error will show
Image

@hugoaguirre hugoaguirre added bug Something isn't working go labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go
Projects
Status: No status
Development

No branches or pull requests

1 participant