Transpose interpolation -> adjoint interpolation #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmaddison
commented
Jan 10, 2025
| @@ -643,7 +653,8 @@ def _interpolate( | |||
| self, | |||
| *function, | |||
| output=None, | |||
| transpose=False, | |||
| transpose=None, | |||
| adjoint=False, | |||
There was a problem hiding this comment.
Using an adjoint argument unfortunately hides the adjoint function. I've worked around this with expr_adjoint but that doesn't seem ideal.
|
There's the caveat that this
|
@dham what are your thoughts? |
I'm fine with this because I think what James is proposing is mathematically correct. The small number of complex users that will even notice can deal with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace transpose interpolation with adjoint interpolation, including the extra complex conjugation.
Fixes #3955