Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check profile data being uploaded #20

Open
arroway opened this issue Nov 6, 2019 · 1 comment
Open

Check profile data being uploaded #20

arroway opened this issue Nov 6, 2019 · 1 comment
Labels

Comments

@arroway
Copy link

arroway commented Nov 6, 2019

To prevent uploads of malicious or unwanted content, we should checking on uploading that profile data match what is expected (format, content...)

@julienw
Copy link
Contributor

julienw commented Nov 18, 2019

Probably we can't check thoroughly the data before it's being uploaded to google storage, in the same server, for performance reason, so the currently planned architecture is that:

  1. The data is uploaded to google storage in "private" mode. Nobody would be able to access this data, not even the uploader.
  2. A request to check this data is pushed to a queue.
  3. The data is checked by another background process.
  4. If the data is deemed correct, its access control is switched to "public".

The process needs to be fast enough that the user doesn't have to wait more than 1 minute.

When we switch to a WebSocket architecture (issue TBD) we can provide progress updates to the uploader.

Things we can check:

  • is it a a valid JSON format
  • does that look like a profile
  • image resolutions for screenshots (and others)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants