Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "tracing" marker type, and migrate to the "category" field. #2749

Open
3 tasks
gregtatum opened this issue Sep 1, 2020 · 3 comments
Open
3 tasks
Labels
markers Anything to do with marker data structures, marker chart, or the marker table

Comments

@gregtatum
Copy link
Member

gregtatum commented Sep 1, 2020

Right now the markers of type "tracing" don't work too nicely with the new marker schema. "type" should be the differentiator on how we display things. However, these markers use a "category" designation instead. This "category" field in the payload should be migrated to the "type" field.

In the marker schema work, I'm working around this by selecting the type OR the category if the type === "tracing".

┆Issue is synchronized with this Jira Task

@gregtatum gregtatum added the markers Anything to do with marker data structures, marker chart, or the marker table label Sep 1, 2020
@mstange
Copy link
Contributor

mstange commented Dec 1, 2020

Yeah I'm pretty sure the "category" field was completely ad-hoc. I think these tracing markers can all be identified by their name and the "category" is not worth preserving.

@mstange
Copy link
Contributor

mstange commented Dec 1, 2020

Yeah, those "Paint" category strings are from the very first addition of tracing markers, in bug 918825.

@mstange
Copy link
Contributor

mstange commented Dec 20, 2024

I've proposed an alternative way forward in #5275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table
Projects
None yet
Development

No branches or pull requests

2 participants