Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postMessage to open external links from sandboxed iframe #5223

Open
nisargjhaveri opened this issue Nov 21, 2024 · 0 comments
Open

Use postMessage to open external links from sandboxed iframe #5223

nisargjhaveri opened this issue Nov 21, 2024 · 0 comments
Labels
feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb

Comments

@nisargjhaveri
Copy link
Contributor

nisargjhaveri commented Nov 21, 2024

VS Code's sandboxes the iframes and does not allow popups (see microsoft/vscode#186043). This means none of the <a target="_blank"> links or window.open works when Firefox Profiler is loaded in VS Code.

The suggested workaround is to use postMessage to send the link and use VS Code provided APIs to open the link in external browser. This requires either changing every instance of these APIs, or overriding window.open and intercepting clicks on <a target="_blank"> using global event listener or document or similar.

Would we be open to implement this here? We can activate this mechanism using some query param. Thoughts? Suggestions?

┆Issue is synchronized with this Jira Task

@julienw julienw added the feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb
Projects
None yet
Development

No branches or pull requests

2 participants