-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ceiling jet heat transfer removes more heat than physically possible #675
Comments
I have run this a reproduced the bug. I will let you know when I figure it out. |
This is related to the enhanced ceiling heat transfer due to the presence of a ceiling jet. If the ceiling jet heat transfer calculation is turned off (defaulting to the regular heat transfer), the problem goes away. |
Rick, 4.5.5 Heat Transfer Constraint |
I have revised the file, there is one compartment, the same as the fire compartment, above. In the results the temperature profile is the same, the ULT is falling.
|
I've found a parameter in the code witch is called zin (position to calculate plume centerline temperature (m)) in the 'fire.f90' file in the part 'get_ceilingjet_tempandvelocity', but i didn't find where this parameter get a size. It can be possible that i had overlook it. |
Unfortunately, it is not a user-selectable setting. I had to change the
code (commenting out line 68 of convection.f90) to eliminate the
calculation. Initial testing seems like this part of the ceiling heat
transfer calculation does not change the results of all of our V&V
results. There's a bit more testing before we put out a patch release.
…On Tue, Apr 18, 2017 at 3:30 AM, JaegerMJ ***@***.***> wrote:
@rpeacoc <https://github.com/rpeacoc> , how and where could i enter this
attitude?
This is related to the enhanced ceiling heat transfer due to the presence
of a ceiling jet. If the ceiling jet heat transfer calculation is turned
off (defaulting to the regular heat transfer), the problem goes away.
|
The parameter zin is an argument to the routine get-ceilingjet_temperatureandvelocity |
I would want to ask how far you are, entire task is for my bachlor thesis. At the moment i write the document in latex and expand my VBA code, which edit the CFAST results. The thesis is not announced yet, up to june there is time avaible. I have to very big thanks at you. I work very much with pleasure at your program, so I would support you with this program. |
Are you running the stock Windows version or a compiled version on another computer platform? |
We have a compiled version, because of the fire equation. The only code we have circumscribed is a the heskestd part in the fire.f90 module. I show you for this a german criteria in a guideline.
The code is only a part of the whole fire.f90 module, i thougt ist was nearly row 511. CFAST exe.zip |
If you're compiling your own executable, the latest repo version works with the test case you submitted above. |
The results of both versions is a falling ULT at the beginning. In my last post i gave you our compiled version, in an .zip file. |
If you have test cases which fail with the unmodified version of CFAST, post them and we'll be happy to look at them. I had to correct errors in you original post file just to allow it to run. With the errors corrected, the latest repo source code, unmodified, does not exhibit a falling layer temperature. We cannot diagnose user-modified versions of the model. |
I think i can limit the bug. |
I did have to make corrections to most of the files to allow them to run. Only the 30000 file would run as supplied. All others exited with an error caused by an incomplete mechanical ventilation specification. If you want to open a vent at a selected temperature, you have to create a target at the appropriate location and associate that target with the vent. Your 30000 test cases had the vent open at a specified time so it worked as supplied. |
CFAST: Add input check for vent openign by flux or temperature to ensure there is an associated target. Addresses part of Issue #675.
We've added a check to the input routine to ensure that the associated target is specified. I'd make sure you delete you existing output files before you run all the cases just in case you are seeing old output files when a cases fails before creating new output files. |
I sorry, but I don't see a falling temperature with the latest test case you supplied. Here's the output from the latest repo version of CFAST with the normal Heskestad plume, repo version 0589e0a: and here's the input file I created from your file, above since it copies without any line formatting (You'll need to change the extension from .txt to .in): |
Make sure you are using the latest source code. The significant change is to convection.f90. Lines 69-71 should look like
There are other changes to define variables, add error checking, and make use of this new ceiling jet calculation, but this should indicate whether you've updated your repo to the latest revision. |
No, the lines in the version i have are not the same, i download the new source code and the new version, i let you know about the next results. |
I have to thank you very much. I downloded the new version and the new source code and compiled the version for my calculations. |
Problem still exists for very large rooms, particularly with very high ceilings. New test case attached. |
Underlying correlation (eq. 5.24 in Tech Ref. assume ceiling is at ambient temperature, thus overestimating the convective flux when the ceiling is actually warmer (and thus closer to the HGL). Need to reformulate to properly calculate enhanced heat transfer coefficient. Information is still in SFPE Handbook. |
For the attached case, the HGL temperature drops below ambient in the first few minutes. The mechanical extraction rate is high, but I do not know why that would drop the temperature below ambient.
The text was updated successfully, but these errors were encountered: