Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Include Ad Type to the Ad_Reporting model #34

Closed
fivetran-joemarkiewicz opened this issue Dec 2, 2021 · 1 comment
Closed
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Are you a Fivetran customer?

Fivetran created PR, but inspired by PR #33

Is your feature request related to a problem? Please describe.

This is not a problem, but rather an enhancement to the package to integrate the respective ad_type of the platforms to the roll up model.

Describe the solution you'd like

All ad platforms integrate the relevant ad_type to the final reporting model.

Describe alternatives you've considered

N/A

Additional context

PR #33 is a great starting point for how we will want to integrate this within the package. However, we need to add these fields at the base packages first.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the enhancement New feature or request label Dec 2, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the wontfix This will not be worked on label Sep 7, 2022
@fivetran-joemarkiewicz
Copy link
Contributor Author

Our team had attempted to include Ad Type into our ad reporting model in the new v1.0.0 updates. However, it seemed inconsistent across platforms.

We did understand that ad_type could be joined in post ad reporting models if a user wished. As such, we opted to allow users of the package to incorporate this field in their own model if they wish. As such, we are opting to not include this in the final model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant