diff --git a/.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md index 768ac3f..3220674 100644 --- a/.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md @@ -4,48 +4,26 @@ **This PR will result in the following new package version:** -**Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:** +**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:** + ## PR Checklist ### Basic Validation Please acknowledge that you have successfully performed the following commands locally: -- [ ] dbt compile -- [ ] dbt run –full-refresh -- [ ] dbt run -- [ ] dbt test -- [ ] dbt run –vars (if applicable) +- [ ] dbt run –full-refresh && dbt test +- [ ] dbt run (if incremental models are present) && dbt test Before marking this PR as "ready for review" the following have been applied: -- [ ] The appropriate issue has been linked and tagged -- [ ] You are assigned to the corresponding issue and this PR +- [ ] The appropriate issue has been linked, tagged, and properly assigned +- [ ] All necessary documentation and version upgrades have been applied +- [ ] docs were regenerated (unless this PR does not include any code or yml updates) - [ ] BuildKite integration tests are passing +- [ ] Detailed validation steps have been provided below ### Detailed Validation -Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review": -- [ ] You have validated these changes and assure this PR will address the respective Issue/Feature. -- [ ] You are reasonably confident these changes will not impact any other components of this package or any dependent packages. -- [ ] You have provided details below around the validation steps performed to gain confidence in these changes. +Please share any and all of your validation steps: -### Standard Updates -Please acknowledge that your PR contains the following standard updates: -- Package versioning has been appropriately indexed in the following locations: - - [ ] indexed within dbt_project.yml - - [ ] indexed within integration_tests/dbt_project.yml -- [ ] CHANGELOG has individual entries for each respective change in this PR - -- [ ] README updates have been applied (if applicable) - -- [ ] DECISIONLOG updates have been updated (if applicable) -- [ ] Appropriate yml documentation has been added (if applicable) - -### dbt Docs -Please acknowledge that after the above were all completed the below were applied to your branch: -- [ ] docs were regenerated (unless this PR does not include any code or yml updates) - ### If you had to summarize this PR in an emoji, which would it be? -:dancer: +:dancer: \ No newline at end of file diff --git a/.github/workflows/auto-release.yml b/.github/workflows/auto-release.yml new file mode 100644 index 0000000..8ed5853 --- /dev/null +++ b/.github/workflows/auto-release.yml @@ -0,0 +1,13 @@ +name: 'auto release' +on: + pull_request: + types: + - closed + branches: + - main + +jobs: + call-workflow-passing-data: + if: github.event.pull_request.merged + uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main + secrets: inherit \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 53d88c4..b0d569b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,13 @@ # dbt_github_source v0.8.0 [PR #39](https://github.com/fivetran/dbt_jira/dbt_github_source/39) contains the following updates: -## Fixes -- materialized +## Feature updates +- Added field `created_at` to model `stg_github__issue_comment`. +- Added default target schemas in `dbt_project.yml`. +- Updated the source freshness test enablement/disablement to leverage the dbt-core `config: enabled` architecture. + +## Contributors +- [@rajan-lw](https://github.com/rajan-lw) ([PR #33](https://github.com/fivetran/dbt_github_source/pull/33)) # dbt_github_source v0.7.1 diff --git a/README.md b/README.md index 1e70c41..76ad87b 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ Include the following github_source package version in your `packages.yml` file. ```yaml packages: - package: fivetran/github_source - version: [">=0.7.0", "<0.8.0"] # we recommend using ranges to capture non-breaking changes automatically + version: [">=0.8.0", "<0.9.0"] # we recommend using ranges to capture non-breaking changes automatically ``` ## Step 3: Define database and schema variables diff --git a/models/src_github.yml b/models/src_github.yml index 0833fd6..759712e 100644 --- a/models/src_github.yml +++ b/models/src_github.yml @@ -75,6 +75,8 @@ sources: description: Foreign key that references the issue table - name: user_id description: Foreign key that references the user table + - name: created_at + description: Timestamp of when the issue comment was created. - name: issue_merged loaded_at_field: _fivetran_synced @@ -151,8 +153,8 @@ sources: - name: repo_team identifier: "{{ var('github_repo_team_identifier', 'repo_team')}}" description: Table representing the mapping relationships between repositories and teams - meta: - is_enabled: "{{ var('github__using_repo_team', true) }}" + config: + enabled: "{{ var('github__using_repo_team', true) }}" columns: - name: repository_id description: Reference to the respective repository for the record. diff --git a/models/stg_github.yml b/models/stg_github.yml index 1758693..ba7d953 100644 --- a/models/stg_github.yml +++ b/models/stg_github.yml @@ -70,6 +70,8 @@ models: description: Foreign key that references the issue table - name: user_id description: Foreign key that references the user table + - name: created_at + description: Timestamp of when the issue comment was created. - name: stg_github__issue_merged description: Table that tracks when an issue (always a pull request) is merged diff --git a/models/stg_github__issue_comment.sql b/models/stg_github__issue_comment.sql index 6c644ac..f48af47 100644 --- a/models/stg_github__issue_comment.sql +++ b/models/stg_github__issue_comment.sql @@ -24,9 +24,10 @@ with issue_comment as ( ), fields as ( select - id as issue_comment_id, - issue_id, - user_id + id as issue_comment_id, + issue_id, + user_id, + created_at from macro )