From a4cc6c621bf4e2873ab3c41ee0d2d9b8c4e76fd7 Mon Sep 17 00:00:00 2001 From: fivetran-reneeli Date: Thu, 7 Sep 2023 16:15:34 -0400 Subject: [PATCH 1/3] test --- packages.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages.yml b/packages.yml index 6e90c38..78f4db0 100644 --- a/packages.yml +++ b/packages.yml @@ -1,3 +1,7 @@ packages: -- package: fivetran/google_ads_source - version: [">=0.9.0", "<0.10.0"] \ No newline at end of file +# - package: fivetran/google_ads_source +# version: [">=0.9.0", "<0.10.0"] + + - git: https://github.com/fivetran/dbt_google_ads_source.git + revision: update_deps_versions + warn-unpinned: false \ No newline at end of file From 03ad429da7aec235bd6dc0abd447207d1b8f4bdc Mon Sep 17 00:00:00 2001 From: fivetran-reneeli Date: Tue, 12 Sep 2023 12:31:31 -0400 Subject: [PATCH 2/3] minor updates to changelog and docs --- CHANGELOG.md | 6 ++++++ DECISIONLOG.md | 7 ++++++- README.md | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cb6ec38..6c671ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +# dbt_google_ads v0.x.x + +## Under the Hood: +- Updates the [dbt-expectations](https://github.com/calogica/dbt-expectations/releases) dependency in the [README](README.md) to the latest version. +- Updates the [DECISIONLOG](DECISIONLOG.md) to clarify why there exist differences among aggregations across different grains. + # dbt_google_ads v0.9.3 [PR #57](https://github.com/fivetran/dbt_google_ads/pull/57) includes the following updates: ## Bug fixes diff --git a/DECISIONLOG.md b/DECISIONLOG.md index e5f6f2a..f2cd974 100644 --- a/DECISIONLOG.md +++ b/DECISIONLOG.md @@ -9,4 +9,9 @@ This logic was only applied to the `google_ads__url_report` and `google_ads__ad_ ## UTM Report Filtering This package contains a `google_ads__url_report` which provides daily metrics for your utm compatible ads. It is important to note that not all Ads within Google's `ad_stats` report do not leverage utm parameters. Therefore, this package takes an opinionated approach to filter out any records that do not contain utm parameters or leverage a url within the ad. -If you would like to leverage a report that contains all ads and their daily metrics, I would suggest you leverage the `google_ads__ad_report` which does not apply any filtering. \ No newline at end of file +If you would like to leverage a report that contains all ads and their daily metrics, I would suggest you leverage the `google_ads__ad_report` which does not apply any filtering. + +## Why don't metrics add up across different grains (Ex. ad level vs campaign level)? +Not all ads are served at the ad level. In other words, there are some ads that are served only at the ad group, campaign, etc. levels. The implications are that since not ads are included in the ad-level report, their associated spend, for example, won't be included at that grain. Therefore your spend totals may differ across the ad grain and another grain. + +This is a reason why we have broken out the ad reporting packages into separate hierarchical end models (Ad, Ad Group, Campaign, and more). Because if we only used ad-level reports, we could be missing data. \ No newline at end of file diff --git a/README.md b/README.md index 15fe86b..0ed571a 100644 --- a/README.md +++ b/README.md @@ -149,7 +149,7 @@ packages: version: [">=0.3.0", "<0.4.0"] - package: calogica/dbt_expectations - version: [">=0.8.0", "<0.9.0"] + version: [">=0.9.0", "<0.10.0"] - package: calogica/dbt_date version: [">=0.7.0", "<0.8.0"] From 1774866e2ab7657b22df9672dbdb32f4826d2a95 Mon Sep 17 00:00:00 2001 From: fivetran-reneeli Date: Thu, 14 Sep 2023 10:37:58 -0400 Subject: [PATCH 3/3] updates --- CHANGELOG.md | 1 + packages.yml | 8 ++------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6c671ad..0ab3d60 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # dbt_google_ads v0.x.x +[PR #58](https://github.com/fivetran/dbt_google_ads/pull/58) includes the following updates: ## Under the Hood: - Updates the [dbt-expectations](https://github.com/calogica/dbt-expectations/releases) dependency in the [README](README.md) to the latest version. - Updates the [DECISIONLOG](DECISIONLOG.md) to clarify why there exist differences among aggregations across different grains. diff --git a/packages.yml b/packages.yml index 78f4db0..9a1e995 100644 --- a/packages.yml +++ b/packages.yml @@ -1,7 +1,3 @@ packages: -# - package: fivetran/google_ads_source -# version: [">=0.9.0", "<0.10.0"] - - - git: https://github.com/fivetran/dbt_google_ads_source.git - revision: update_deps_versions - warn-unpinned: false \ No newline at end of file +- package: fivetran/google_ads_source + version: [">=0.9.0", "<0.10.0"]