Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable Campaigns and Programs by Default #41

Open
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Dec 4, 2024 · 0 comments · May be fixed by #43
Open
1 of 4 tasks

[Feature] Enable Campaigns and Programs by Default #41

fivetran-joemarkiewicz opened this issue Dec 4, 2024 · 0 comments · May be fixed by #43
Assignees
Labels
good first issue Good for newcomers type:enhancement New functionality or enhancement

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently the marketo__enable_campaigns and marketo__enable_programs are disabled by default. This results in the marketo__campagins and the marketo__programs models be turned off by default.

However, now with the advent of Quickstart we can rely on the Quickstart Data Model to handle the enable/disable components of the above variables dynamically. As such, we should create a breaking change to swap the default value for these variables to be true to ensure that these models are captured by Quickstart and other users by default.

This will require users leverage the package outside of Quickstart to ensure the variables are disabled if necessary. We will need to call this out clearly in the CHANGELOG release notes. This change will also need to be made at the source package level as well to enable the staging models by default.

How would you implement this feature?

Enable the models by default instead of disabling them. The relevant updates would look like the following:

Before

{{ config(enabled=var('marketo__enable_campaigns', False) and var('marketo__enable_programs', False)) }}

After

{{ config(enabled=var('marketo__enable_campaigns', True) and var('marketo__enable_programs', True)) }}

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:enhancement New functionality or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants