Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] expand default LEAD columns #34

Open
2 of 4 tasks
fivetran-jamie opened this issue Feb 22, 2024 · 0 comments
Open
2 of 4 tasks

[Feature] expand default LEAD columns #34

fivetran-jamie opened this issue Feb 22, 2024 · 0 comments
Assignees
Labels
status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@fivetran-jamie
Copy link
Contributor

fivetran-jamie commented Feb 22, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

currently, we include all columns we find in stg_marketo__lead, but we only ensure that the following fields are included in the table: ['id', 'created_at', 'updated_at', 'email', 'first_name', 'last_name', '_fivetran_synced']. These are the only fields we include in the get_lead_columns() macro.

However, there are quite a few more default fields for the LEAD table, which are outlined here.

Some of these fields will be necessary for our upcoming Customer360 work, namely:

  • phone
  • main_phone
  • mobile_phone
  • company
  • inferred_company
  • address_lead
  • address
  • city
  • state
  • state_code (not in this doc but we have it internally?)
  • country
  • country_code (not in this doc but we have it internally?)
  • postal_code
  • billing_street
  • billing_city
  • billing_state
  • billing_state_code (not in this doc but we have it internally?)
  • billing_country
  • billing_country_code (not in this doc but we have it internally?)
  • billing_postal_code
  • inferred_city
  • inferred_state_region
  • inferred_country
  • inferred_postal_code
  • inferred_phone_area_code
  • anonymous_ip
  • unsubscribed
  • email_invalid
  • do_not_call

In the off chance that a user does not have the above, I'd like to ensure that the customer360 package runs successfully. Thus, let's add these columns to the get_lead_columns macro and to this line and document them in yml.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-jamie fivetran-jamie self-assigned this Feb 26, 2024
@fivetran-jamie fivetran-jamie added type:enhancement New functionality or enhancement status:in_progress Currently being worked on update_type:models Primary focus requires model updates labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

1 participant