Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-action-result #38

Merged
merged 12 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# dbt_marketo_source v0.12.0
[PR #38](https://github.com/fivetran/dbt_marketo_source/pull/38) includes the following updates:

## Breaking Change
- Added the `action_result` field in the `stg_marketo__activity_send_email` model to capture email action outcomes, allowing for filtering in downstream models.
- *Note:* If you have previously added this field via the `marketo__activity_send_email_passthrough_columns` variable, remove or alias it there to prevent duplicate column errors. See the [README](https://github.com/fivetran/dbt_marketo_source?tab=readme-ov-file#passing-through-additional-columns) for more details on working with passthrough columns.

## Documentation Update
- Added `action_result` details to dbt documentation.

## Under the Hood
- Updated seed data to include `action_result`.
- Updated the `get_activity_send_email_columns` macro to support `action_result`.

# dbt_marketo_source v0.11.0
[PR #35](https://github.com/fivetran/dbt_marketo_source/pull/35) includes the following updates:

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ If you are **not** using the [Marketo transformation package](https://github.co
```yml
packages:
- package: fivetran/marketo_source
version: [">=0.11.0", "<0.12.0"]
version: [">=0.12.0", "<0.13.0"]
```

### Step 3: Define database and schema variables
Expand All @@ -70,7 +70,7 @@ vars:
```

### (Optional) Step 5: Additional configurations
<details><summary>Expand for details</summary>
<details open><summary>Expand/collapse details</summary>
<br>

#### Passing Through Additional Columns
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'marketo_source'
version: '0.11.0'
version: '0.12.0'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
models:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

47 changes: 10 additions & 37 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'marketo_source_integration_tests'
version: '0.11.0'
version: '0.12.0'
profile: 'integration_tests'
config-version: 2
vars:
Expand Down
202 changes: 101 additions & 101 deletions integration_tests/seeds/marketo_activity_send_email_data.csv

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions macros/get_activity_send_email_columns.sql
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

{% set columns = [
{"name": "_fivetran_synced", "datatype": dbt.type_timestamp()},
{"name": "action_result", "datatype": dbt.type_string()},
{"name": "activity_date", "datatype": dbt.type_timestamp()},
{"name": "activity_type_id", "datatype": dbt.type_int()},
{"name": "campaign_id", "datatype": dbt.type_int()},
Expand Down
Loading