Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
int_netsuite2__tran_with_converted_amounts
#153This PR will result in the following new package version:
v0.17.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
This release involves breaking changes and will require running a full refresh.
Bug Fixes
int_netsuite2__tran_with_converted_amounts
model from incremental to ephemeral. There was a previous issue with the incremental strategy that could potentially produce duplicate records in certain situations (PR #153).Feature Updates
netsuite2__balance_sheet
andnetsuite2__income_statement
models (PR #151):transaction_amount
subsidiary_currency_symbol
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
full refresh validation tests pass
as do incremental
If you had to summarize this PR in an emoji, which would it be?
💱