Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/v0.17.latest #154

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Releases/v0.17.latest #154

merged 5 commits into from
Dec 18, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Dec 17, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

v0.17.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

This release involves breaking changes and will require running a full refresh.

Bug Fixes

  • Adjusted the materialization of the int_netsuite2__tran_with_converted_amounts model from incremental to ephemeral. There was a previous issue with the incremental strategy that could potentially produce duplicate records in certain situations (PR #153).
    • Our team has determined that the most sensible path forward is to remove the incremental logic for this model entirely, as its performance benefits have proved marginal and an ephemeral materialization will avoid any duplication issues.

This is a Breaking Change, as int_netsuite2__tran_with_converted_amounts will no longer materialize in the warehouse.

Feature Updates

  • Added two fields to the netsuite2__balance_sheet and netsuite2__income_statement models (PR #151):
    • transaction_amount
    • subsidiary_currency_symbol

This change will require running a full refresh, as we are adding new fields to incrementally materialized models.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

full refresh validation tests pass
image

as do incremental
image

If you had to summarize this PR in an emoji, which would it be?

💱

jmongerlyra and others added 3 commits November 27, 2024 13:21
Added transaction_amount to balance_sheet & income_statement
…unts` (#153)

* working

* Docs

* docs

* Update CHANGELOG.md

Co-authored-by: Joe Markiewicz <[email protected]>

* joe feedback

---------

Co-authored-by: Joe Markiewicz <[email protected]>
@fivetran-jamie fivetran-jamie self-assigned this Dec 17, 2024
@fivetran-jamie fivetran-jamie marked this pull request as ready for review December 17, 2024 21:35
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie Left a couple suggested but otherwise approved!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: fivetran-catfritz <[email protected]>
@fivetran-jamie fivetran-jamie merged commit 19261a9 into main Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants