Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendar date in the profit and loss model should be the last day of the month #80

Closed
2 of 4 tasks
caffeinebounce opened this issue Apr 4, 2023 · 2 comments · Fixed by #124
Closed
2 of 4 tasks
Assignees
Labels
status:scoping Currently being scoped

Comments

@caffeinebounce
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

From a financial reporting perspective, items in each row include items through the last day of the month. However, the profit and loss model pulls through the period_first_day instead of the period_last_day from the GL by period table, which seems a lot more logical.

Relevant error log or model output

/

Expected behavior

/

dbt Project configurations

/

Package versions

/

What database are you using dbt with?

snowflake

dbt Version

/

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@caffeinebounce caffeinebounce added the bug Something isn't working label Apr 4, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added status:scoping Currently being scoped and removed bug Something isn't working labels Apr 5, 2023
@fivetran-reneeli fivetran-reneeli mentioned this issue May 13, 2024
7 tasks
@fivetran-reneeli fivetran-reneeli self-assigned this May 13, 2024
@fivetran-reneeli fivetran-reneeli linked a pull request May 13, 2024 that will close this issue
7 tasks
@fivetran-reneeli
Copy link
Contributor

This has been addressed in the latest release (v0.13.0) of this package. As such we'll be closing this issue out!

@fivetran-reneeli
Copy link
Contributor

  • Addressed in v0.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:scoping Currently being scoped
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants