[Bug Fix] Net income adjustment for no revenue/expense lines

[fivetran-avinash]

PR Overview

This PR will address the following Issue/Feature: [#145]

This PR will result in the following new package version:

Non breaking change as we are only changing the logic to ensure revenue and expense lines are brought down and kept not null

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fix

• Updated the logic in int_quickbooks__retained_earnings to ensure accounting periods with no revenue and expense class lines were accounted for.
  • This will ensure the net income adjustment is available regardless of existing revenue or expenses.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Validation on development production was passing.

Customer also confirmed pre-release worked as expected on Quickstart.

If you had to summarize this PR in an emoji, which would it be?

🩺

[fivetran-joemarkiewicz]

Not approving yet since this is not intended to be merged as of this moment. However, this is appropriate to cut a pre-release off for v0.17.1-a1

[fivetran-avinash]

This is now ready for official PR review.

[fivetran-joemarkiewicz]

These changes look good to me. However, I noticed not related to these changes, but in this update we didn't bring the created_at and updated_at fields into the final invoice double entry query (see here). Can you please add those into this update as well.

[fivetran-avinash]

@fivetran-joemarkiewicz Changes applied. Ready for re-review

[fivetran-joemarkiewicz]

LGTM