-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add created_at
and updated at
fields
#58
Changes from 7 commits
a3fbaa0
afab644
489a4ce
3c9907e
2f5f6ef
3b02e42
d6202c8
ac8a46c
196a72e
f7d3b30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,13 @@ | ||||||
# dbt_quickbooks_source v0.12.0 | ||||||
[PR #58](https://github.com/fivetran/dbt_quickbooks_source/pull/57) introduces the following updates: | ||||||
|
||||||
## Breaking Changes | ||||||
- We introduced these pre-existing timestamp fields from these sources to their equivalent staging models to better analyze real-time transaction data: | ||||||
- `created_at`: `bill`, `bill_payment`, `credit_memo`, `invoice`, `payment`, `transfer` | ||||||
- `updated_at`: `bill`, `bill_payment`, `credit_memo`, `deposit`, `invoice`, `journal_entry`, `payment`, `purchase`, `refund_receipt`, `sales_receipt`, `transfer`, `vendor_credit` | ||||||
- These new fields are then being brought in downstream in the `dbt_quickbooks` package in the `quickbooks__general_ledger` model via the double entry transaction intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- As this introduces new columns to our staging models and changes our schema, this will be a breaking change. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
# dbt_quickbooks_source v0.11.0 | ||||||
[PR #57](https://github.com/fivetran/dbt_quickbooks_source/pull/57) introduces the following updates: | ||||||
|
||||||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: 'quickbooks_source_integration_tests' | ||
version: '0.11.0' | ||
version: '0.12.0' | ||
|
||
|
||
profile: 'integration_tests' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would list the field and the exact staging models they were added to instead of requiring the user to have to match them up on their own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz Listing all the staging models would get a bit wordy, so I did a slight tweak to your suggestion. Let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True--this makes sense!