Skip to content

Commit

Permalink
review updates and docs regen
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-joemarkiewicz committed Dec 12, 2023
1 parent e8547a6 commit 93a1fe8
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 20 deletions.
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
target/
dbt_modules/
logs/

dbt_packages/
env/
dbt_packages/
package-lock.yml
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

[PR #8](https://github.com/fivetran/dbt_reddit_ads/pull/8) includes the following updates:
## Bug Fixes
- This package now leverages the new `reddit_ads_extract_url_parameter()` for use in parsing out url parameters. This was added to create special logic for Databricks instances not supported by `dbt_utils.get_url_parameter()`.
- This macro will be replaced with the `fivetran_utils.extract_url_parameter()` in the next breaking change.
- This package now leverages the new `reddit_ads_extract_url_parameter()` macro for use in parsing out url parameters. This was added to create special logic for Databricks instances not supported by `dbt_utils.get_url_parameter()`.
- This macro will be replaced with the `fivetran_utils.extract_url_parameter()` macro in the next breaking change of this package.
## Under the Hood
- Included auto-releaser GitHub Actions workflow to automate future releases.

Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion macros/reddit_ads_extract_url_parameters.sql
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% macro reddit_ads_extract_url_parameter(field, url_parameter) -%}

{{ adapter.dispatch('reddit_ads_extract_url_parameter', 'reddit_ads') (field, url_parameter) }}
{{ return(adapter.dispatch('reddit_ads_extract_url_parameter', 'reddit_ads') (field, url_parameter)) }}

{% endmacro %}

Expand Down

0 comments on commit 93a1fe8

Please sign in to comment.