Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Update Quickstart.yml casing #61

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Jan 17, 2025

PR Overview

This PR will address the following Issue/Feature: [#60]

This PR will result in the following new package version: 1.1.2

Should enable new functionality in Quickstart but does not change the schema.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Quickstart Fixes

  • Fixed casing syntax in quickstart.yml to match the default Salesforce connector schema. Source tables are now in upper case, and snake casing is updated to camel casing.
    • Now Quickstart customers can now properly reference the source tables. Customers can now enable or disable them as they wish.

Documentation

  • Added Quickstart model counts to README. (#59)
  • Corrected references to connectors and connections in the README. (#59)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Screenshot 2025-01-17 at 3 43 20 PM

If you had to summarize this PR in an emoji, which would it be?

@fivetran-avinash fivetran-avinash self-assigned this Jan 17, 2025
fivetran-avinash and others added 4 commits January 17, 2025 15:51
* MagicBot/add-model-counts updates

* Update README.md

* update connector to connection

---------

Co-authored-by: Avinash Kunnath <[email protected]>
Co-authored-by: Avinash Kunnath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants